Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault when new attachment is done to shutting down database #7626

Closed
AlexPeshkoff opened this issue Jun 13, 2023 · 3 comments
Closed

Segfault when new attachment is done to shutting down database #7626

AlexPeshkoff opened this issue Jun 13, 2023 · 3 comments
Assignees
@AlexPeshkoff
Labels
affect-version: 3.0.10 affect-version: 4.0.2 affect-version: 5.0 Beta 1 fix-version: 3.0.11 fix-version: 4.0.3 fix-version: 5.0 RC 1 type: bug

Comments

@AlexPeshkoff
Copy link
Member

In core dump, received from user, I see same attachment released in 2 threads simultaneously - in attachments shutdown thread and in worker thread from unwindAttach. Not strange that this causes segfault in one of that threads.
@AlexPeshkoff AlexPeshkoff self-assigned this Jun 13, 2023
@AlexPeshkoff
Copy link
Member Author

AlexPeshkoff commented Jun 13, 2023 •
edited

Bug happens cause in internalAttach (and createDatabase) blocking mutex is released too early, before unwindAttach. User is running FB4, but bug affects other branches too, starting with FB3.

@AlexPeshkoff
Copy link
Member Author

@omachtandras What you mention is quite unrelated with this bug. What I've seen in core dump has absolutely nothing to do with mon$ tables.

@omachtandras
Copy link

@omachtandras What you mention is quite unrelated with this bug. What I've seen in core dump has absolutely nothing to do with mon$ tables.

Sorry, I mixed up the issues, that's why I deleted my comment.

AlexPeshkoff added a commit that referenced this issue Jul 6, 2023
@AlexPeshkoff
Fixed #7626: Segfault when new attachment is done to shutting down da…
6749faa 
…tabase
AlexPeshkoff added a commit that referenced this issue Jul 6, 2023
@AlexPeshkoff
Fixed #7626: Segfault when new attachment is done to shutting down da…
b27c25a 
…tabase

(cherry picked from commit 6749faa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexPeshkoff AlexPeshkoff

Labels
affect-version: 3.0.10 affect-version: 4.0.2 affect-version: 5.0 Beta 1 fix-version: 3.0.11 fix-version: 4.0.3 fix-version: 5.0 RC 1 type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexPeshkoff @omachtandras