Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows distribution with new zlib version 1.3 (released 2023-08-18) #7755

Closed
basid-irk opened this issue Sep 20, 2023 · 5 comments
Closed

Comments

@basid-irk
Copy link

Version 1.3 has these key updates from 1.2.13:
    Building using K&R (pre-ANSI) function definitions is no longer supported.
    Fixed a bug in deflateBound() for level 0 and memLevel 9.
    Fixed a bug when gzungetc() is used immediately after gzopen().
    Fixed a bug when using gzflush() with a very small buffer.
    Fixed a crash when gzsetparams() is attempted for a transparent write.
    Fixed test/example.c to work with FORCE_STORED.
    Fixed minizip to allow it to open an empty zip file.
    Fixed reading disk number start on zip64 files in minizip.
    Fixed a logic error in minizip argument processing.
@asfernandes
Copy link
Member

As the fix is Windows only, and Linux build requires different type of fixes for different versions, I think this issue must be renamed to be specific about Windows and another one must be created for Linux.

@hvlad hvlad changed the title zlib version 1.3 released 2023-08-18 Update Windows distribution with new zlib version 1.3 (released 2023-08-18) Oct 6, 2023
@AlexPeshkoff
Copy link
Member

I doubt linux build requires anything - we always rely on system zlib.

@asfernandes
Copy link
Member

I doubt linux build requires anything - we always rely on system zlib.

Sorry, I get confused by the zlib used in the docker builder with crosstoolng, thinking it was statically linked in Firebird.
But this is about the toolchain only.

Anyway, this fix (ang bug) is really about Windows only.

@hvlad
Copy link
Member

hvlad commented Oct 6, 2023

Anyway, this fix (ang bug) is really about Windows only.

What bug ? You mean - this ticket ?

@asfernandes
Copy link
Member

Anyway, this fix (ang bug) is really about Windows only.

What bug ? You mean - this ticket ?

Yes, it's arguable if update of a vulnerable library is improvement or bug, but no need to discuss it, I was just meaning "this issue".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants