Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SKIP LOCKED implementation #7810

Closed
hvlad opened this issue Oct 20, 2023 · 2 comments · Fixed by #7811 or #7872
Closed

Improve SKIP LOCKED implementation #7810

hvlad opened this issue Oct 20, 2023 · 2 comments · Fixed by #7811 or #7872
Assignees
@hvlad
Labels
affect-version: 5.0 RC 1 affect-version: 6.0 Initial component: engine fix-version: 5.0 RC 2 fix-version: 6.0 Alpha 1 qa: done successfully type: improvement

Comments

@hvlad
Copy link
Member

hvlad commented Oct 20, 2023

Make SKIP LOCKED works in all transaction isolation levels, including RC NRV
Avoid preliminary lock for UPDATE and DELETE statements

More details at thread "SKIP LOCKED problems" in fb-devel
https://groups.google.com/g/firebird-devel/c/BIbAz_YJMFw
@hvlad hvlad self-assigned this Oct 20, 2023
@hvlad hvlad mentioned this issue Oct 20, 2023
Merged
@hvlad hvlad linked a pull request Oct 20, 2023 that will close this issue
Improve SKIP LOCKED implementation #7811
Merged
@hvlad hvlad removed a link to a pull request Oct 20, 2023
Improve SKIP LOCKED implementation #7811
Merged
@hvlad hvlad linked a pull request Oct 20, 2023 that will close this issue
Improve SKIP LOCKED implementation #7811
Merged
hvlad added a commit that referenced this issue Nov 20, 2023
@hvlad
Merge branch 'work/gh-7810-improve-skip-locked-implementation' of htt…
9b1f9c6 
…ps://github.com/FirebirdSQL/firebird into work/gh-7810-improve-skip-locked-implementation
@hvlad
Copy link
Member Author

hvlad commented Nov 22, 2023

The fix #7811 introduced bug in DELETE RETURNING handling - calculated fields now returned as NULL's.
Thus some additional work is required.
Also, documentation should be updated.
Re-opened to fix these issues.

@hvlad hvlad reopened this Nov 22, 2023
@hvlad hvlad linked a pull request Nov 23, 2023 that will close this issue
Additional fixes for #7810 (Improve SKIP LOCKED implementation) #7872
Merged
hvlad added a commit that referenced this issue Nov 24, 2023
@hvlad
Merge pull request #7872 from FirebirdSQL/work/gh-7810-2
5b240c4 
Additional fixes for #7810 (Improve SKIP LOCKED implementation)
@pavel-zotov
Copy link

QA note.
Test checks only UPDATE and DELETE behavior.
Ability to run 'SELECT ... WITH LOCK' is checked in gh_7350_test.py

asfernandes added a commit that referenced this issue Nov 25, 2023
@asfernandes
Postfix for #7810 - allow empty statements.
c39e937
asfernandes added a commit that referenced this issue Nov 25, 2023
@asfernandes
Postfix for #7810 - thanks to Vlad.
f5e81c6
hvlad added a commit that referenced this issue Nov 27, 2023
@hvlad
Backported feature #7810 : Improve SKIP LOCKED implementation
dc2d85c 
(#7811 and #7872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvlad hvlad

Labels
affect-version: 5.0 RC 1 affect-version: 6.0 Initial component: engine fix-version: 5.0 RC 2 fix-version: 6.0 Alpha 1 qa: done successfully type: improvement
Projects
None yet
Milestone
No milestone
3 participants
@dyemanov @hvlad @pavel-zotov