Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to handle attach errors in key holder plugin. #7951

Closed
AlexPeshkoff opened this issue Jan 11, 2024 · 3 comments
Closed

Make it possible to handle attach errors in key holder plugin. #7951

AlexPeshkoff opened this issue Jan 11, 2024 · 3 comments

Comments

@AlexPeshkoff
Copy link
Member

In some cases (like encryption key entered by user in dialogue mode) it's very useful to be able to handle attach errors in key holder in order to be able to repeat with modified key value.

@AlexPeshkoff
Copy link
Member Author

Solution ported from HQbird. Old key holders will proceed to work and compile as earlier.

AlexPeshkoff added a commit that referenced this issue Jan 24, 2024
@pavel-zotov
Copy link

@@@ QA issue @@@

It's probably impossible to do a test for this ticket.
But indirectly it can be checked by following actions:

  1. add into firebird.conf parameter KeyHolderPlugin = fbSampleKeyHolder;
  2. copy files fbSampleKeyHolder.conf & fbSampleKeyHolder.dll from %FB_HOME\examples\prebuilt\plugins\ to %FB_HOME\plugins\
  3. run b/r of employee with specifying "-par " where <N> for sure more than number of logical CPUs, e.g.:
    %FB_HOME%\gbak -b -m -g localhost:employee stdout | %FB_HOME%\gbak -rep -v -par 99 stdin localhost:C:\FB\60sS\examples\empbuild\tmp.fdb -z 1>C:\TEMP\tmprestore.log.tmp 2>&1
  4. get number of occurrences of string 'WARNING:' in the log:
    find /i /c "warning" C:\TEMP\tmprestore.log.tmp

Output of 'find' command must be:
------- C:\TEMP\tmprestore.log.tmp: 1

PS.
Problem initially was encountered when test tests/functional/tabloid/test_333be4bf.py started failing since 6.0.0.213 (15.01.2024).
(line with "WARNING:" missed there).

@AlexPeshkoff
Copy link
Member Author

Rather useless test. It checks correct error handling in remote client. That has nothing to do with ability to handle errors in key holder plugin.

AlexPeshkoff added a commit that referenced this issue Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants