Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Int128 datatype not supported in FB_MESSAGE macro #8006

Closed
AlexPeshkoff opened this issue Feb 14, 2024 · 6 comments
Closed

Int128 datatype not supported in FB_MESSAGE macro #8006

AlexPeshkoff opened this issue Feb 14, 2024 · 6 comments
Assignees
@AlexPeshkoff
Labels
affect-version: 4.0.4 affect-version: 5.0.0 affect-version: 6.0 Initial fix-version: 4.0.5 fix-version: 5.0.1 fix-version: 6.0 Alpha 1 type: bug

Comments

@AlexPeshkoff
Copy link
Member

Bug was reported to me by user privately.

An attempt to use int128 field in UDR fails when trying to describe it in the message.
@AlexPeshkoff AlexPeshkoff self-assigned this Feb 14, 2024
@AlexPeshkoff AlexPeshkoff reopened this Feb 14, 2024
@aafemt
Copy link
Contributor

aafemt commented Feb 14, 2024

It looks rather as "an attempt to use Int128 in a static buffer" than "in UDR"...

@AlexPeshkoff
Copy link
Member Author

in a static message buffer ?

@aafemt
Copy link
Contributor

aafemt commented Feb 14, 2024

...or however is called this ugly bunch of macros and templates in Message.h. In your commit I see no changes anywhere else. Did I miss something?

@AlexPeshkoff AlexPeshkoff changed the title Int128 datatype not supported in UDR Int128 datatype not supported FB_MESSAGE macro Feb 14, 2024
@AlexPeshkoff
Copy link
Member Author

No more changes except small one in related example.
BTW, you may call that macros ugly but they help make required changes in single place, and people use it.

@aafemt
Copy link
Contributor

aafemt commented Feb 14, 2024

Still it is not related to UDR in any manner and can be used anywhere in API code.

@AlexPeshkoff AlexPeshkoff changed the title Int128 datatype not supported FB_MESSAGE macro Int128 datatype not supported in FB_MESSAGE macro Feb 14, 2024
@AlexPeshkoff
Copy link
Member Author

Still it is not related to UDR in any manner and can be used anywhere in API code.

Yes, therefore I've renamed this ticket

AlexPeshkoff added a commit that referenced this issue Feb 18, 2024
@AlexPeshkoff
Fixed #8006: Int128 datatype not supported in UDR
54a7a19
AlexPeshkoff added a commit that referenced this issue Feb 18, 2024
@AlexPeshkoff
Fixed #8006: Int128 datatype not supported in UDR
5f2197f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexPeshkoff AlexPeshkoff

Labels
affect-version: 4.0.4 affect-version: 5.0.0 affect-version: 6.0 Initial fix-version: 4.0.5 fix-version: 5.0.1 fix-version: 6.0 Alpha 1 type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexPeshkoff @aafemt