Fixed CORE-6055: Xnet crypt #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tonal I wonder with what plugin did you test your code. |
|
@AlexPeshkoff The plugin is our internal development. |
AlexPeshkoff
requested changes
Jul 8, 2019
There was a problem hiding this comment.
Not tested... That explains everything. That's bad idea to submit patch requests with untested changes.
Unfortunately this would not work. Yep, this change is required part of making xnet pass db crypt keys over the wire but that is not enough - one should also learn xnet to handle async operations in async way (like TCP does). And that's definitely more complex task.
|
see #6305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.