Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use restricted list of C++11 features #48

Merged
merged 12 commits into from Sep 22, 2016
Merged

Use restricted list of C++11 features #48

merged 12 commits into from Sep 22, 2016

Conversation

asfernandes
Copy link
Member

No description provided.

@asfernandes
Copy link
Member Author

@dyemanov what about merge this pull request?

@AlexPeshkoff
Copy link
Member

On 21.09.2016 18:46, Adriano dos Santos Fernandes wrote:

@dyemanov what about merge this pull request?

With what compilers did you try it ?

@hvlad
Copy link
Member

hvlad commented Sep 21, 2016

IIRC, snapshot build for Windows still produced using VC10 (VS2010). I doubt it supports all features in this branch.

@dyemanov
Copy link
Member

@hvlad, snapshots are built using MSVC13.

@asfernandes
Copy link
Member Author

@AlexPeshkoff clang++ 3.8.0, g++ 5.4.0 and MSVC 14.

@dyemanov
Copy link
Member

Compiles fine with MSVC2013, does not compile with MSVC10. More or less as expected.

@aafemt
Copy link
Contributor

aafemt commented Sep 21, 2016 via email

@asfernandes
Copy link
Member Author

No distro includes FB 4.

@aafemt
Copy link
Contributor

aafemt commented Sep 21, 2016 via email

@hvlad
Copy link
Member

hvlad commented Sep 21, 2016

snapshots are built using MSVC13.

Very good :) No objection from my side

@AlexPeshkoff
Copy link
Member

AlexPeshkoff commented Sep 21, 2016

Should better work with at least gcc 4.9. It's compiler used in current stable gentoo.
$ gcc --version
gcc (Gentoo 4.9.3 p1.4, pie-0.6.4) 4.9.3

@asfernandes
Copy link
Member Author

@AlexPeshkoff can you test it then?

@dyemanov
Copy link
Member

Tested with gcc 4.8.2, the branch compiles fine.

@AlexPeshkoff
Copy link
Member

With 4.9.3 it alsi builds fine.
I think it's time to merge it.

@aafemt
Copy link
Contributor

aafemt commented Sep 22, 2016

I think it's time to merge it.

If you have time, merge PR #15 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants