Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultSet::getInfo() implementation #7083

Merged
merged 3 commits into from Apr 23, 2022
Merged

ResultSet::getInfo() implementation #7083

merged 3 commits into from Apr 23, 2022

Conversation

dyemanov
Copy link
Member

@dyemanov dyemanov commented Dec 21, 2021

At the moment only record count is supported. I've decided to return a special value -1 for uni-directional cursors, because it appears we never return isc_infona (what a pity) and only in one case return isc_infinap, so I'm not sure applications and libraries are prepared to get an error code for a properly valid info tag.

Now it's good time to consider other possible information requests and I will add them before the merge. Possible options:

  • whether prefetch is enabled or not
  • whether cursor is updatable
  • cursor name
  • mirror opcodes for isc_info_sql_records / isc_info_sql_get_plan / isc_info_sql_explain_plan (useful if result set is created via Attachment::openCursor())

Any other suggestions?

@dyemanov dyemanov marked this pull request as ready for review December 21, 2021 10:14
@aafemt
Copy link
Contributor

aafemt commented Dec 21, 2021

Cursor name is never generated by server but always set by client application. I see no harm in it but no necessity as well.

@dyemanov dyemanov merged commit 44b76cc into master Apr 23, 2022
@dyemanov dyemanov deleted the cursor-info branch April 23, 2022 06:15
@dyemanov dyemanov self-assigned this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants