Fix MacOS UDR and Legacy_UserManager plugins not working due to not exported entry point. #7088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xported entry point. Add FB_DLL_EXPORT to public headers. Use default visibility also for Linux/Unix (in addition to MacOS) as user application can also be compiled with -fvisibility=hidden.
| #if defined(WIN32) || defined(_WIN32) || defined(__WIN32__) | ||
| #define FB_DLL_EXPORT __declspec(dllexport) | ||
| #elif defined(__APPLE__) || defined(__linux__) || defined(unix) || defined(__unix__) || defined(__unix) | ||
| #define FB_DLL_EXPORT __attribute__ ((visibility("default"))) |
There was a problem hiding this comment.
I'm not sure - does __attribute__ ((visibility("default"))) work in non-GCC case? I.e. is not check for unix too wide, may be something like check for defined(__GNUC__) should be added?
There was a problem hiding this comment.
Another problem here is that __declspec() must be used BEFORE function name while attribute() - AFTER it. I.e. declaration void FB_DLL_EXPORT foo() won't work with GCC.
There was a problem hiding this comment.
I'm not sure - does attribute ((visibility("default"))) work in non-GCC case? I.e. is not check for unix too wide, may be something like check for defined(GNUC) should be added?
Or maybe this?
https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005fattribute.html
|
On 12/24/21 19:39, Dimitry Sibiryakov wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In src/include/ibase.h
<#7088 (comment)>:
> @@ -64,6 +64,14 @@
#define FB_API_DEPRECATED
#endif
+#if defined(WIN32) || defined(_WIN32) || defined(__WIN32__)
+#define FB_DLL_EXPORT __declspec(dllexport)
+#elif defined(__APPLE__) || defined(__linux__) || defined(unix) || defined(__unix__) || defined(__unix)
+#define FB_DLL_EXPORT __attribute__ ((visibility("default")))
Another problem here is that __declspec() must be used BEFORE function
name while *attribute*() - AFTER it. I.e. declaration |void
FB_DLL_EXPORT foo()| won't work with GCC.
According to https://gcc.gnu.org/wiki/Visibility it works.
|
|
It looks like it can work in form |
|
On 12/24/21 20:00, Adriano dos Santos Fernandes wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In src/include/ibase.h
<#7088 (comment)>:
> @@ -64,6 +64,14 @@
#define FB_API_DEPRECATED
#endif
+#if defined(WIN32) || defined(_WIN32) || defined(__WIN32__)
+#define FB_DLL_EXPORT __declspec(dllexport)
+#elif defined(__APPLE__) || defined(__linux__) || defined(unix) || defined(__unix__) || defined(__unix)
+#define FB_DLL_EXPORT __attribute__ ((visibility("default")))
I'm not sure - does *attribute* ((visibility("default"))) work in
non-GCC case? I.e. is not check for unix too wide, may be
something like check for defined(*GNUC*) should be added?
Or maybe this?
https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005fattribute.html
Certainly, it's ok.
|
asfernandes
force-pushed
the
work/macos-plugins
branch
from
d6757d0
to
d074c94
Compare
AlexPeshkoff
approved these changes
Dec 25, 2021
asfernandes
added a commit
to asfernandes/firebird
that referenced
this pull request
Dec 27, 2021
…xported entry point. (FirebirdSQL#7088) Add FB_DLL_EXPORT to public headers. Use default visibility also for Linux/Unix (in addition to MacOS) as user application can also be compiled with -fvisibility=hidden.
asfernandes
added a commit
that referenced
this pull request
Dec 27, 2021
…xported entry point. (#7088) Add FB_DLL_EXPORT to public headers. Use default visibility also for Linux/Unix (in addition to MacOS) as user application can also be compiled with -fvisibility=hidden.
asfernandes
added a commit
that referenced
this pull request
Dec 27, 2021
…xported entry point. (#7088) Add FB_DLL_EXPORT to public headers. Use default visibility also for Linux/Unix (in addition to MacOS) as user application can also be compiled with -fvisibility=hidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FB_DLL_EXPORT to public headers.
Use default visibility also for Linux/Unix (in addition to MacOS) as
user application can also be compiled with -fvisibility=hidden.