New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invariants optimization involving views (#7388) #7390
Conversation
Is it possible to see difference of such execution in explain plan? |
I agree it could be useful. Will take look at possible implementation. |
This is the suggested plan output:
|
Will be good to see both plans in new version.
and second version
or it will look differently?
and second version
|
|
Most sub-queries are correlated in practice, so reporting them as "variant" IMO is about to cause more questions than keeping is simple. |
Yes, my concern was only if for variant there will be |
Plan explain improvements will be applied separately. |
The idea is that we should not compare view field's stream with streams from other RSEs until the field has been expanded to the proper expression. Once it's done,
sub->pass1()
will recursively take care of the invariant checking. The test case from #7388 now shows good performance in both cases, but I'd like to have a second opinion.