Fix performance issues in prepare_update() #7662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comparison in prepare_update() which causes the temporary record to be inserted twice
…update() when the record which is being updated has 3 or more fragments
hvlad
approved these changes
Jul 13, 2023
dyemanov
approved these changes
Jul 13, 2023
|
The first commit is only for FB5 but the second one is actual for FB3/4. Should I backport it? |
|
I don't mind about backporting. @hvlad, what do you think ? |
Agree |
ilya071294
added a commit
that referenced
this pull request
Jul 20, 2023
Fix an issue where the temporary record is inserted twice in prepare_update() when the record which is being updated has 3 or more fragments
ilya071294
added a commit
that referenced
this pull request
Jul 20, 2023
Fix an issue where the temporary record is inserted twice in prepare_update() when the record which is being updated has 3 or more fragments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits in the PR fix similar cases where the temporary record is inserted twice in prepare_update().