Fix the footer to the bottom, by making the nav a reasonable minimum height. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could probably do something similar but a little more flexible if I switched to a flexbox layout, but that seems like a lot of work, so I'm not sure it's worth it… |
bwinton
force-pushed
the
footer
branch
2 times, most recently
from
1fae676
to
3e9eaf1
Compare
|
The footer looks good, but now the content is pushed far to the right. it was always a bit too much to the right I think, somehow it is even further now |
|
Content should be fixed now, and even less over than it used to be. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337.