Support DBAL 4; drop DBAL 3 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==============================================
+ Coverage 88.00% 100.00% +12.00%
+ Complexity 24 21 -3
==============================================
Files 5 5
Lines 100 83 -17
==============================================
- Hits 88 83 -5
+ Misses 12 0 -12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be any reasonable way to support both.
While the literal type signatures don't change for any public API code, that's only due to the fact that there's no native typed arrays in PHP. Consequently, this is a BC break. I've added an UPGRADING document to indicate how to handle this (testing this in a real application, I needed no change since I wasn't logging or otherwise using the affected parameter)