Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action may continue even if push fails #34

Closed
Firehed opened this issue Nov 29, 2022 · 2 comments · Fixed by #35
Closed

Action may continue even if push fails #34

Firehed opened this issue Nov 29, 2022 · 2 comments · Fixed by #35
Labels
bug Something isn't working

Comments

@Firehed
Copy link
Owner

Firehed commented Nov 29, 2022

https://github.com/Firehed/multistage-docker-build-action/actions/runs/3504039849/jobs/6015269075

Screen Shot 2022-11-29 at 10 20 44 AM

Noticed this while trying to diagnose build failures in #32. It doesn't seem to be consistent; I've seen push failures correctly cause this action to fail before.
@Firehed Firehed added the bug Something isn't working label Nov 29, 2022
@Firehed
Copy link
Owner Author

Firehed commented Dec 13, 2022

This is not limited to push failures - any step in the build failing appears to replicate the issue:
Screen Shot 2022-12-13 at 3 17 48 PM

@Firehed Firehed mentioned this issue Dec 14, 2022
Merged
@Firehed
Copy link
Owner Author

Firehed commented Dec 14, 2022

During working on #35, it looks like this may have been a regression introduced in #29: https://github.com/Firehed/multistage-docker-build-action/pull/29/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R22-R24

Firehed added a commit that referenced this issue Dec 14, 2022
@Firehed
Ensure action fails when internal steps do (#35)
69ae61a 
Fixes #34, which is apparently a regression introduced in #29
(20c0bcd).

This also adds `eslint` which would likely have caught the issue
earlier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure action fails when internal steps do Firehed/multistage-docker-build-action
1 participant
@Firehed