Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4: Update snapshot generator for type slicing #1051

Closed
wmrutten opened this issue Jul 22, 2019 · 3 comments
Closed

R4: Update snapshot generator for type slicing #1051

wmrutten opened this issue Jul 22, 2019 · 3 comments
Assignees
Labels

Comments

@wmrutten
Copy link
Contributor

Update the snapshot generator implementation according to changes discussed with Grahame at DevDays US in Redmond.

Specifically, type slice in snapshot should always include slicing component. Slicing component may be omitted from the differential (implicit/redundant for type slice); in that case, the generator should emit a default type slicing component to the snapshot.

WARNING! R4 API packages did NOT process type slices correctly. Once this has been fixed, customers will have to re-generate some existing snapshots.

@wmrutten wmrutten added the bug label Jul 22, 2019
@wmrutten wmrutten self-assigned this Jul 22, 2019
@wmrutten
Copy link
Contributor Author

@wmrutten
Copy link
Contributor Author

Test results are published here:
https://gist.github.com/wmrutten/acc5e24601eb74df582ff39b21f41efc

@ewoutkramer
Copy link
Member

Fixed for R4 in #1088

ewoutkramer pushed a commit that referenced this issue Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants