Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Namespace for R4 Subsetted Tag #2033

Closed
brianpos opened this issue Apr 4, 2022 · 0 comments
Closed

Wrong Namespace for R4 Subsetted Tag #2033

brianpos opened this issue Apr 4, 2022 · 0 comments
Labels
bug

Comments

@brianpos
Copy link
Collaborator

brianpos commented Apr 4, 2022 •
edited
Loading

firely-net-sdk/src/Hl7.Fhir.Core/Serialization/BaseFhirSerializer.cs

Line 76 in 35fb12f

if (!resource.Meta.Tag.Any(t => t.System == "http://hl7.org/fhir/v3/ObservationValue" && t.Code == "SUBSETTED"))

This should be using http://terminology.hl7.org/CodeSystem/v3-ObservationValue
as per https://www.hl7.org/fhir/v3/ObservationValue/cs.html

Hoping this is all and it isn't somewhere in the common area too.
brianpos added a commit that referenced this issue Apr 11, 2022
@brianpos
#2033 Wrong namespace for the SUBSETTED type (was changed between STU…
f851912 
…3 and R4)

(cherry picked from commit 5df53e879e9c0e49ee25cfd0c3172f9f152fa427)
(cherry picked from commit 7473546578f83304ce73cfc5ab07cf9213210e29)
@brianpos brianpos mentioned this issue Apr 11, 2022
Closed
marcovisserFurore pushed a commit that referenced this issue Apr 20, 2022
@brianpos @marcovisserFurore
#2033 Wrong namespace for the SUBSETTED type (was changed between STU…
6d09053 
…3 and R4)

(cherry picked from commit 5df53e879e9c0e49ee25cfd0c3172f9f152fa427)
(cherry picked from commit 7473546578f83304ce73cfc5ab07cf9213210e29)
@marcovisserFurore marcovisserFurore mentioned this issue Apr 20, 2022
Merged
marcovisserFurore added a commit that referenced this issue Apr 21, 2022
@marcovisserFurore
Merge pull request #2047 from FirelyTeam/release/feature/2033-wrong-n…
cfc6d78 
…amespace-subsetted-type-r4

#2033 Wrong namespace for the SUBSETTED type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Firely .NET SDK
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianpos @marcovisserFurore