Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FhirPath function memberOf implementation #2404

Closed
marcovisserFurore opened this issue Mar 8, 2023 · 3 comments
Closed

FhirPath function memberOf implementation #2404

marcovisserFurore opened this issue Mar 8, 2023 · 3 comments
Assignees
@marcovisserFurore
Labels
enhancement Firely Favorite
Milestone
FhirPath functions

Comments

@marcovisserFurore
Copy link
Member

marcovisserFurore commented Mar 8, 2023 •
edited

The FP function memberOf is not implemented yet. . Is there a way to implement this FP function?
@brianpos
Copy link
Collaborator

brianpos commented Mar 8, 2023 •
edited

I did a POC of this here
https://github.com/brianpos/fhirpath-lab-dotnet/blob/master/fhirpath-lab-dotnet/Helpers/FhirPathTerminologies.cs
Which is used in the fhirpath lab

@marcovisserFurore marcovisserFurore mentioned this issue Mar 30, 2023
Closed
@marcovisserFurore marcovisserFurore added this to the FhirPath functions milestone Mar 30, 2023
@ewoutkramer
Copy link
Member

I don't really understand the way this is solved, @brianpos - I think we should just add a terminology service to the FhirEvaluationContext and invoke that service from the function. Am I missing something?

@brianpos
Copy link
Collaborator

Provided that is able to reach out and call an external service too I'm good with that.
Admittedly, the code I've referenced here is for the other terminology related functions in the fhirpath spec, not this specific one.

@marcovisserFurore marcovisserFurore mentioned this issue May 3, 2023
Merged
2 tasks
marcovisserFurore added a commit that referenced this issue May 7, 2023
@marcovisserFurore
Merge pull request #2450 from FirelyTeam/feature/2404-FhirPath-memberOf
dfd7201 
#2404: Implementation of FhirPath function memberOf()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcovisserFurore marcovisserFurore

Labels
enhancement Firely Favorite
Projects
Firely .NET SDK
Status: Done
Milestone
FhirPath functions
Development

No branches or pull requests
3 participants
@brianpos @ewoutkramer @marcovisserFurore