Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot generator clears slicing element for extension header base element definitions that are referenced in annotations #2466

Closed
Rob5045 opened this issue May 21, 2023 · 0 comments
Closed

Snapshot generator clears slicing element for extension header base element definitions that are referenced in annotations #2466

Rob5045 opened this issue May 21, 2023 · 0 comments
Assignees
@Rob5045
Labels
bug Firely Favorite

Comments

@Rob5045
Copy link
Contributor

Rob5045 commented May 21, 2023 •
edited
Loading

In Forge the slicing details of a extension header are marked as modified because the base definition for the element definition does not contain the slicing element (the element definition itself does) and thus Forge sees this a a change. I believe the base definition for extension headers should contain the slicing element.

image

Fix and unit test can be found here:
#2467
@Rob5045 Rob5045 mentioned this issue May 21, 2023
Merged
@Rob5045 Rob5045 changed the title Snapshot generator clears slicing element for extension header base element definitions Snapshot generator clears slicing element for extension header base element definitions referenced in annotations May 21, 2023
@Rob5045 Rob5045 changed the title Snapshot generator clears slicing element for extension header base element definitions referenced in annotations Snapshot generator clears slicing element for extension header base element definitions that are referenced in annotations May 21, 2023
@Rob5045 Rob5045 self-assigned this May 21, 2023
Rob5045 added a commit that referenced this issue May 23, 2023
@Rob5045
Added fix for #2466 to STU3 + unit tests.
8ff8e48
marcovisserFurore added a commit that referenced this issue May 23, 2023
@marcovisserFurore
Merge pull request #2467 from FirelyTeam/bugfix/2466-slicing-cleared-…
32854d2 
…in-base-extension-header

#2466 ElementMatcher no longer clears the slicing element of an extension element when the match action is slice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rob5045 Rob5045

Labels
bug Firely Favorite
Projects
Firely .NET SDK
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcovisserFurore @Rob5045