Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArtifactSummaryGenerator should return error summaries with file information #892

Closed
wmrutten opened this issue Mar 5, 2019 · 0 comments
Closed

ArtifactSummaryGenerator should return error summaries with file information #892

wmrutten opened this issue Mar 5, 2019 · 0 comments
Assignees
@wmrutten
Labels
bug

Comments

@wmrutten
Copy link
Contributor

wmrutten commented Mar 5, 2019

The ArtifactSummaryGenerator class captures runtime exceptions and returns error summaries, allowing clients to list invalid files. However the returned error summaries do not initialize the ArtifactSummary.Origin property that actually identifies the offending file.

Proposal: the ArtifactSummaryGenerator should initialize error summaries with basic file properties (Origin, FileSize, LastModified).
wmrutten added a commit to wmrutten/fhir-net-api that referenced this issue Mar 5, 2019
@wmrutten
fix: FirelyTeam#892 fix build error...
c7e92d6
wmrutten added a commit to wmrutten/fhir-net-api that referenced this issue Mar 5, 2019
@wmrutten
fix: FirelyTeam#892 fix unit tests
8f26667
@wmrutten wmrutten self-assigned this Mar 5, 2019
@ewoutkramer ewoutkramer added the bug label Mar 6, 2019
wmrutten added a commit to wmrutten/fhir-net-api that referenced this issue Apr 15, 2019
@wmrutten
fix: FirelyTeam#952 - DirectorySource.Summaries - ignore unknown file…
78f758c 
… extensions

Depends on FirelyTeam#892
@wmrutten wmrutten mentioned this issue Apr 15, 2019
Closed
ewoutkramer added a commit that referenced this issue Apr 16, 2019
@ewoutkramer
Merge pull request #893 from wmrutten/feature-stu3/892-ArtifactSummar…
a2932d5 
…yGeneratorErrorFileInfo

fix: #892 - ArtifactSummaryGenerator should return error summaries with file information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wmrutten wmrutten

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ewoutkramer @wmrutten