_sort did not allow the use of underscore search parameter such as '_lastUpdated' #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…results there was a bug in the API in that it checked that values of the _sort must begin with a character that is either a letter or '-' for decreasing order. However, this rule neglected the case where the search parameter being used to sort was one of the 'Parameters for all resources' which all begin with an underscore character '_'. The prime example of this would be '[base]/Patient?_sort=lastUpdated' This commit adds support for underscore and a new test case.
|
Thanks @angusmillar , will do a PR now so it will become part of the upcoming 1.3 release. |
ewoutkramer
pushed a commit
that referenced
this pull request
Jun 27, 2019
_sort did not allow the use of underscore search parameter such as '_lastUpdated'
|
I also created a PR (#1003) with a cherry pick for this to STU3. |
ewoutkramer
pushed a commit
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the '_sort' search result parameter to order the returned results there was a bug in the API in that it checked that values of the sort must begin with a character that is either a letter or '-' for decreasing order. However, this rule neglected the case where the search parameter being used to sort was one of the 'Parameters for all resources' which all begin with an underscore character ''. The prime example of this would be '[base]/Patient?_sort=_lastUpdated'
This commit adds support for underscore and a new test case.