STU3: Behavior of PocoStuctureDefinitionSummaryProvider is now the same as StuctureDefinitionSummaryProvider #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CarePlan.activity.detail.status - ConceptMap.group.element.target.equivalence - Group.characteristic.exclude - List.entry.deleted - MedicationRequest.substitution.allowed
ewoutkramer
previously approved these changes
Jul 14, 2021
|
Don't pull this PR until we have a consensus on Zulip: https://chat.fhir.org/#narrow/stream/294899-dotnet.2Fcommitters/topic/Summary.20elements |
marcovisserFurore
added
the
breaking change
ewoutkramer
previously approved these changes
Aug 5, 2021
marcovisserFurore
changed the base branch from
develop-stu3
to
release/4.0.0-beta1-stu3
marcovisserFurore
changed the base branch from
release/4.0.0-beta1-stu3
to
develop-stu3
marcovisserFurore
dismissed
ewoutkramer’s stale review
The base branch was changed.
marcovisserFurore
changed the base branch from
develop-stu3
to
release/4.0.0-beta1-stu3
# Conflicts: # common
…pocosdsp-isdsp # Conflicts: # src/Hl7.Fhir.Core.Tests/Serialization/SummarySerializationTests.cs # src/firely-net-sdk.props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The behavior of
PocoStuctureDefinitionSummaryProvideris now the same asStuctureDefinitionSummaryProvider. The solution was to remove the attribute InSummary=true for the following pocos elements:Those elements had this
InSummaryattribute while it was absent in the FHIR specification. Therefor the attributeInSummaryhas been removed.The FhirAttribite
IsModifierhas been added to Poco elements according to the FHIR specification._summary=trueis now depedent onIsModifierorInSummary.See also FirelyTeam/firely-net-common#138
See also PR FirelyTeam/fhir-codegen#14 in FirelyTeam/fhir-codegen
Related issues
Resolves #1576.
Testing
See unittest
Hl7.Fhir.Specification.Tests.PocoAndSdSummaryProvidersShouldBeEqual()FirelyTeam Checklist