Fix for PR #1990 #1999
Merged
Fix for PR #1990 #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se of mergeMin and MergeMax in ElementDefnMerger already fixes the issue. Added constrainMax (not used) and unit tests. Updated snapshot generator unit tests.
marcovisserFurore
requested changes
Mar 2, 2022
marcovisserFurore
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1990 did not solve the issue (checked with additional unit tests). That is because the use of the new mergeMin and MergeMax methods in ElementDefnMerger is enough to fix both #1824 and #1981. The additonal code in mergeTypeProfiles to set the Min/Max of the rebasedRootElem is no longer valid.
Related issues
Resolves #1981 and #1824.
Testing
Additional unit tests were added for CardinalityOfExtension.