Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solution to .NET 8 #2677

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Update solution to .NET 8 #2677

merged 5 commits into from
Jan 22, 2024

Conversation

mmsmits
Copy link
Member

@mmsmits mmsmits commented Jan 22, 2024

Dropping .NET 6 keeping netstandard2.0, for backwards compatibility

ewoutkramer
ewoutkramer previously approved these changes Jan 22, 2024
@mmsmits
Copy link
Member Author

mmsmits commented Jan 22, 2024

forgot to update the dotnet sdk for running the unit tests. Fixed this so this doesn't happen again next time.

@mmsmits
Copy link
Member Author

mmsmits commented Jan 22, 2024

As of .NET 8 Microsoft not only not recommends the use of BinaryFormatter, they are throwing an error if you have not explicitly enabled it.
I think we can safely do that, since we only use this in the test classes, but please review.
More info: https://learn.microsoft.com/en-us/dotnet/standard/serialization/binaryformatter-security-guide

@mmsmits mmsmits merged commit 11a97cc into develop Jan 22, 2024
15 checks passed
@mmsmits mmsmits deleted the feature/update-to-net80 branch January 22, 2024 16:38
@mmsmits
Copy link
Member Author

mmsmits commented Jan 23, 2024

fixes #2674

@mmsmits mmsmits linked an issue Jan 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to .NET8.0
2 participants