keep snapshot when differential is missing #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g) to create a new snapshot if the differential is missing.
mmsmits
previously approved these changes
Apr 3, 2024
…-differential-is-missing
mmsmits
previously approved these changes
Apr 3, 2024
…shot-when-differential-is-missing' into 2586-snapshotgenerator-keep-snapshot-when-differential-is-missing
mmsmits
approved these changes
Apr 3, 2024
…-differential-is-missing
mmsmits
deleted the
2586-snapshotgenerator-keep-snapshot-when-differential-is-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SnapshotGenerator should now do a no-op when asked to update a snapshot if the structure has no differential. In some cases this used to lead to removal of a snapshot.
Related issues
Fixes #2586
Testing
Added unit test to check the specific case in which this bug would occur