Fix compile errors with Hl7.Fhir.R4 version 4.x #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As newer firely implements IEnumerable<X> in more classes, we check that X = Element before actually doing traversal. Without this test, an illegal cast exception is generated.
Newer Firely library has where T: struct, Enum.
|
Thanks, I'll have a look at this later! |
| // If this member is an IEnumerable<Element>, go inside and recurse | ||
| if (property.PropertyType.GetInterface("IEnumerable`1") != null) |
There was a problem hiding this comment.
Strange that this doesn't work already, it seems we should already be filtering properly in propertyFilter(). Can you instead of doing another filtering on IEnumerable<Element> see how we can improve propertyFilter()?
|
On 17.08.2022 20:22, Kenneth Myhra wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In src/Spark.Engine/Auxiliary/ResourceVisitor.cs
<#502 (comment)>:
> // If this member is an IEnumerable<Element>, go inside and recurse
- if (property.PropertyType.GetInterface("IEnumerable`1") != null)
Strange that this doesn't work already, it seems we should already be
filtering properly in |propertyFilter()|. Can you instead of doing
another filtering on |IEnumerable<Element>| see how we can improve
|propertyFilter|()?
The "problem" stems from
FirelyTeam/firely-net-common@81f58a7
this adds IReadOnlyDictionary<KeyValuePair<string, object>>, which again
inherits from IEnumerable<KVP<s, o>>. So the code fails because the
propertyFilter also returns Element properties, and they are handled later.
Agree, the code could probably be cleaner factoring out the predicates
from the two functions.
… Message ID: ***@***.***>
|
Share predicate to discriminate between single element properties and enumerable of elements. Same function call => clearer intentions.
kennethmyhra
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have done some minimal testing with Hl7.Fhir.R4 version 4.1.0, but have hit some snags that seems to be fixed with a couple of small changes, that I believe should not have any implications on the functionality. But I am not very familiar with code base.