Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faceting from Elastic #56

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Add faceting from Elastic #56

merged 3 commits into from
Oct 18, 2023

Conversation

Firesphere
Copy link
Owner

This is lacking automated tests at the moment, due to a lack of copy-paste-ability on my side.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (9b88d99) 87.31% compared to head (5eafa14) 84.47%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #56      +/-   ##
============================================
- Coverage     87.31%   84.47%   -2.84%     
- Complexity      202      213      +11     
============================================
  Files            14       14              
  Lines           662      702      +40     
============================================
+ Hits            578      593      +15     
- Misses           84      109      +25     
Files Coverage Δ
src/Queries/QueryBuilder.php 91.60% <75.00%> (-4.77%) ⬇️
src/Results/SearchResult.php 67.61% <5.00%> (-13.78%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firesphere Firesphere merged commit 7cf5ec9 into main Oct 18, 2023
2 of 4 checks passed
@Firesphere Firesphere deleted the hans/facets branch October 18, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant