Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hans/psr18adapter #221

Closed
wants to merge 8 commits into from
Closed

Hans/psr18adapter #221

wants to merge 8 commits into from

Conversation

Firesphere
Copy link
Owner

Hi there and thank you for taking the time and effort to make a Pull Request

No, seriously, we are delighted you made time and effort to help us, even in the smallest way!

Please check the following

  • Have you opened an issue to discuss the feature and agree its general design?
  • Do you have a use case and, ideally, an example program using the feature?
  • Do you have tests covering 90%+ of the feature code (and, of course passing)
  • Have you written complete and accurate doc comments?
  • Have you updated the README or docs where needed?
  • Code is readable
  • Code is tested
  • I've read the Code of Conduct (Or, at least, I do believe I agree with it)
  • Frontend features don't look completely uncared for
  • Code is PSR-2 compliant
  • I'm fairly sure this is useful
  • I'm not just making this PR for HacktoberFest
  • You rock. Thanks a lot.

@Firesphere Firesphere mentioned this pull request Jul 4, 2020
Closed
@Firesphere
Copy link
Owner Author

This requires a new build of the php/solr image, as it requires PHP 7.2

@marczhermo Can you have a look and maybe make a tag so we can have branch 1.0 and 2.0 side by side?

@Firesphere Firesphere closed this Oct 4, 2020
@Firesphere Firesphere reopened this Oct 4, 2020
@Firesphere Firesphere changed the base branch from master to primary October 4, 2020 03:58
@Firesphere Firesphere mentioned this pull request Apr 21, 2022
Closed
@Firesphere
Copy link
Owner Author

Closing in favour of newer PR

@Firesphere Firesphere closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Firesphere