Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Guzzle HTTP Adapter to PSR Adapter #254

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Conversation

Firesphere
Copy link
Owner

Hi there and thank you for taking the time and effort to make a Pull Request

No, seriously, we are delighted you made time and effort to help us, even in the smallest way!

Please check the following

  • Have you opened an issue to discuss the feature and agree its general design?
  • Do you have a use case and, ideally, an example program using the feature?
  • Do you have tests covering 90%+ of the feature code (and, of course passing)
  • Have you written complete and accurate doc comments?
  • Have you updated the README or docs where needed?
  • Code is readable
  • Code is tested
  • I've read the Code of Conduct (Or, at least, I do believe I agree with it)
  • Frontend features don't look completely uncared for
  • Code is PSR-2 compliant
  • I'm fairly sure this is useful
  • I'm not just making this PR for HacktoberFest
  • You rock. Thanks a lot.

@Firesphere
Copy link
Owner Author

#247

You should be able to use dev-hans/guzzle-to-psr for PHP8 compatibility.

No promises though!

@Firesphere
Copy link
Owner Author

@marczhermo Could you please have a look at your Docker container, to update the PHP version to 7.3+, and maybe/possibly PHP8 as a secondary build track?

@@ -17,6 +17,8 @@
use Firesphere\SolrSearch\Traits\CoreServiceTrait;
use GuzzleHttp\Client as GuzzleClient;
use GuzzleHttp\HandlerStack;
use Http\Discovery\HttpClientDiscovery;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Firesphere,
Can we add php-http/discovery:^1.14 to composer.json?
I got this error below:

[Emergency] Uncaught Error: Class 'Http\Discovery\HttpClientDiscovery' not found

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Of course!

@Firesphere
Copy link
Owner Author

Hey Marco,

I've added and updated this PR, it's now ready to go. Test failing is unrelated and work locally, I'll fix up the tests on master when I get to it.

This adds:

  • Solarium 6
  • Solr 9
  • PSR18 instead of Guzzle

@Firesphere Firesphere marked this pull request as ready for review July 23, 2022 01:44
require at least PHP7.3

Solr 9 compatibility

Flatten hierarchy to avoid Solr thinking it's a child document

Add required PSR adapters
Copy link
Contributor

@ssmarco ssmarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solr 9 🎉

@Firesphere Firesphere merged commit bb22cec into primary Aug 18, 2022
@Firesphere Firesphere deleted the hans/guzzle-to-psr branch October 23, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants