-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new entry for TPM info #16
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -486,7 +486,9 @@ The following entry types are currently defined: | |
- single HOB block entry: tag_id = 2 (:numref:`hob_block_entry`). | ||
- HOB list entry: tag_id = 3 (:numref:`hob_list_entry`). | ||
- ACPI table aggregate entry: tag_id = 4 (:numref:`acpi_aggr_entry`). | ||
- Entries related to Trusted Firmware (:numref:`tf_entries`) | ||
- TPM event log entry: tag_id = 5 (:numref:`tpm_evlog_entry`). | ||
- TPM CRB base entry: tag_id = 6 (:numref:`tpm_crb_base_entry`). | ||
- Entries related to Trusted Firmware (:numref:`tf_entries`). | ||
|
||
.. _void_entry: | ||
|
||
|
@@ -697,6 +699,105 @@ such that the last ACPI table in this entry ends at offset | |
- hdr_size | ||
- One or more ACPI tables. | ||
|
||
|
||
.. _tpm_evlog_entry: | ||
|
||
TPM event log table entry layout (XFERLIST_EVLOG) | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
This entry type holds TPM-related information for a platform. The TPM event log | ||
info is a region containing a TPM event log as defined by TCG EFI Protocol | ||
Specification [TCG_EFI]_. | ||
|
||
.. _tab_tpm_evlog: | ||
.. list-table:: TPM event log type layout | ||
:widths: 2 2 4 8 | ||
|
||
* - Field | ||
- Size (bytes) | ||
- Offset (bytes) | ||
- Description | ||
|
||
* - tag_id | ||
- 0x3 | ||
- 0x0 | ||
- The tag_id field must be set to **5**. | ||
|
||
* - hdr_size | ||
- 0x1 | ||
- 0x3 | ||
- |hdr_size_desc| | ||
|
||
* - data_size | ||
- 0x4 | ||
- 0x4 | ||
- The size of the event log in bytes + sizeof(flags) i.e. 0x4. | ||
|
||
* - flags | ||
- 0x4 | ||
- hdr_size | ||
- flags are intended to signal properties of this TE. Bit 0 is | ||
need_to_replay flag. Some firmware components may compute measurements | ||
to be extended into a TPM and add them to the TPM event log, but those | ||
components are unable to access the TPM themselves. In this case, the | ||
component should set the "need_to_replay" flag so that the next | ||
component in the boot chain is aware that the PCRs have not been | ||
extended. A component with access to the TPM would replay the event log | ||
by reading each measurement recorded and extending it into the TPM. Once | ||
the measurements are extended into the TPM, then the "need_to_replay" | ||
flag must be cleared if the transfer list is passed to additional | ||
firmware components. Default value is "0". Other bits should be set to | ||
zero. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. minor: As I said in an earlier review, it would be good to align with the TL header language: "Must be set to 0 or ignored". |
||
|
||
* - event_log | ||
- data_size - 0x4 | ||
- hdr_size + 0x4 | ||
- Holds a complete event log. | ||
|
||
|
||
.. _tpm_crb_base_entry: | ||
|
||
TPM CRB base address table entry layout (XFERLIST_TPM_CRB_BASE) | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
The CRB info defines the address of a region of memory that has been carved out | ||
and reserved for use as a TPM Command Response Buffer interface. | ||
|
||
.. _tab_tpm_crb_base: | ||
.. list-table:: TPM CRB base type layout | ||
:widths: 4 2 4 8 | ||
|
||
* - Field | ||
- Size (bytes) | ||
- Offset (bytes) | ||
- Description | ||
|
||
* - tag_id | ||
- 0x3 | ||
- 0x0 | ||
- The tag_id field must be set to **6**. | ||
|
||
* - hdr_size | ||
- 0x1 | ||
- 0x3 | ||
- |hdr_size_desc| | ||
|
||
* - data_size | ||
- 0x4 | ||
- 0x4 | ||
- This value should be set to **0xc** i.e. sizeof(crb_base_address) + sizeof(crb_size). | ||
|
||
* - crb_base_address | ||
apalos marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- 0x8 | ||
- hdr_size | ||
- The physical base address of a region of memory reserved for use as a | ||
TPM's Command Response Buffer region. | ||
|
||
* - crb_size | ||
- 0x4 | ||
- hdr_size + 0x8 | ||
- Size of CRB. | ||
|
||
|
||
|
||
.. _tf_entries: | ||
|
||
Entries related to Trusted Firmware | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: After re-reading this, it's ambiguous whether the "i.e. 0x4" applies to the sizeof(flags) or the overall data_size. Hopefully it's obvious to implementers.