Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add standard TEs for OPTEE #19

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

raymo200915
Copy link
Contributor

@raymo200915 raymo200915 commented Sep 26, 2023

Add XFERLIST_OPTEE_PAGABLE_PART for OPTEED pagable part address.
Add XFERLIST_SPMC_MANIFEST for SPMC manifest.

source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
@raymo200915 raymo200915 temporarily deployed to pr_ci September 29, 2023 12:39 — with GitHub Actions Inactive
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@danh-arm danh-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few other minor comments

source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
@raymo200915
Copy link
Contributor Author

All comments have been addressed. Squashed and pushed the commit.

source/transfer_list.rst Outdated Show resolved Hide resolved
@raymo200915
Copy link
Contributor Author

All comments have been addressed. Squashed and pushed the commit.

sjg20
sjg20 previously approved these changes Oct 11, 2023
Copy link
Contributor

@sjg20 sjg20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is OK, so long as the next project doesn't have to leave 256 positions!

@raymo200915
Copy link
Contributor Author

All comments have been addressed. Squashed and pushed the commit.

@raymo200915
Copy link
Contributor Author

Just a few other minor comments

Comments are addressed.

@raymo200915 raymo200915 reopened this Oct 12, 2023
@raymo200915 raymo200915 temporarily deployed to pr_ci October 20, 2023 08:48 — with GitHub Actions Inactive
@raymo200915 raymo200915 temporarily deployed to pr_ci October 20, 2023 15:16 — with GitHub Actions Inactive
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
@raymo200915
Copy link
Contributor Author

All comments have been addressed. A new commit is pushed.

sjg20
sjg20 previously approved these changes Nov 1, 2023
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
@raymo200915
Copy link
Contributor Author

All comments have been addressed. Please review.

sjg20
sjg20 previously approved these changes Nov 7, 2023
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
source/transfer_list.rst Outdated Show resolved Hide resolved
danh-arm
danh-arm previously approved these changes Nov 9, 2023
Copy link
Contributor

@danh-arm danh-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are only minor so I'll approve this. But it would be nice to fix them.

source/transfer_list.rst Outdated Show resolved Hide resolved
source/references.rst Outdated Show resolved Hide resolved
Add XFERLIST_OPTEE_PAGEABLE_PART_ADDR for OP-TEE.
Add XFERLIST_DT_SPMC_MANIFEST for TF-A.

Signed-off-by: Raymond Mao <raymond.mao@linaro.org>
@raymo200915
Copy link
Contributor Author

Fixed a few minor issues commented by @danh-arm and @sjg20 .

@danh-arm danh-arm merged commit 29aeb41 into FirmwareHandoff:main Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants