Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approach (an adaptor for each way? a duplex? ...?) #1

Open
Fishrock123 opened this issue Oct 30, 2018 · 3 comments
Open

Approach (an adaptor for each way? a duplex? ...?) #1

Fishrock123 opened this issue Oct 30, 2018 · 3 comments

Comments

@Fishrock123
Copy link
Owner

Heya @mcollina, @mafintosh

I've made two base classes, assuming that would be the easiest to start from.

I guess in the future a duplex might be the simplest adaptor? Not sure.

I don't really know how to integrate the pull-y-ness into the regular streams3 api though... we probably need to go deep and mess with events and such I guess?

readable-sink.js & writable-source.js

@mcollina
Copy link
Collaborator

I would go with a different approach, and completely encapsulate the source and the sink. IMHO our Readable should act as a Sink for Bob, and Writable as a Source. Something like

Source --> ReadableSink --> Readable
Writable --> WritableSource --> Sink

@Fishrock123
Copy link
Owner Author

Maybe I wasn't clear, I think that was the same plan as mine.

I do wonder if it should just be one 'duplex' though. Guess we'll find out in time.

@mcollina
Copy link
Collaborator

mcollina commented Oct 31, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants