filter console logs based on app uuid (#204)

filter console logs based on app uuid Signed-off-by: Oana Pleșu <oanaplesu@google.com>
Fitbit · Aug 25, 2022 · 68a08d3 · 68a08d3
1 parent 5396fba
commit 68a08d3
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 0 deletions.
diff --git a/packages/sdk-cli/src/models/LogConsumer.test.ts b/packages/sdk-cli/src/models/LogConsumer.test.ts
@@ -174,6 +174,7 @@ describe('LogConsumer', () => {
           companion: componentSourceMaps,
           settings: componentSourceMaps,
         },
+        uuid: 'fakeUUID',
       } as any;
 
       sourceMapConsumers = {
@@ -233,6 +234,32 @@ describe('LogConsumer', () => {
       });
     });
 
+    it('processes the log message because uuids match', async () => {
+      await logConsumer.registerHost(registerAppHostObject);
+      const testMessage = {
+        emittedBy: {
+          uuid: 'fakeUUID',
+          component: 'app' as ComponentType,
+        },
+      };
+
+      appHost.emit('consoleMessage', testMessage);
+      expect(messageFormatter).toBeCalledWith(testMessage);
+    });
+
+    it('discards the log message because uuids do not match', async () => {
+      await logConsumer.registerHost(registerAppHostObject);
+      const testMessage = {
+        emittedBy: {
+          uuid: 'fakeUUID2',
+          component: 'app' as ComponentType,
+        },
+      };
+
+      appHost.emit('consoleMessage', testMessage);
+      expect(messageFormatter).not.toBeCalledWith(testMessage);
+    });
+
     it('does not register source maps if an appPackage does not exist', async () => {
       appContext.appPackage = undefined;
       await logConsumer.registerSourceMaps();

diff --git a/packages/sdk-cli/src/models/LogConsumer.ts b/packages/sdk-cli/src/models/LogConsumer.ts
@@ -94,6 +94,14 @@ export default class LogConsumer {
   };
 
   private handleLog = (message: ConsoleMessage) => {
+    if (
+      this.componentSourceMapConsumers[message.emittedBy.component] &&
+      this.appContext.appPackage &&
+      message.emittedBy.uuid !== this.appContext.appPackage.uuid
+    ) {
+      return;
+    }
+
     this.messageFormatter(
       sourceMapMessage(message, this.componentSourceMapConsumers),
     );