Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory-profiler: Convert to V8 Heap Dump #192

Merged
merged 1 commit into from
Jun 28, 2022
Merged

memory-profiler: Convert to V8 Heap Dump #192

merged 1 commit into from
Jun 28, 2022

Conversation

keitwb
Copy link
Contributor

@keitwb keitwb commented May 18, 2022

This replaces the old output format in favor of a V8 Heap Snapshot
which is usable in Chrome Dev Tools.

This will hopefully be useful in debugging heap usage even though
it is not quite as full of metadata compared to the heap snapshots taken
from a normal V8 app.

This also adds the ability to export the heap snapshot to GEXF for use
in graphing tools like Gephi.

Also included is the ability to launch a REPL to manually explore the heap
graph.

Signed-off-by: Ben Keith keitwb@gmail.com

@keitwb keitwb requested a review from a team May 18, 2022 02:05
@coveralls
Copy link

coveralls commented May 18, 2022

Coverage Status

Coverage remained the same at 94.25% when pulling 9b0f799 on keitwb:memory-profiler-v8 into bd2053d on Fitbit:master.

Copy link
Contributor

@Hexxeh Hexxeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into the CI error since I don't think it's related and get this merged, thank you! :)

packages/memory-profiler/README.md Outdated Show resolved Hide resolved
@Hexxeh
Copy link
Contributor

Hexxeh commented Jun 23, 2022

This should be good for a rebase, I've rebased and run yarn checkstyle -w to run the formatter on another branch and it all looks happy. I'd do it, but I don't think I have access to change the branch this PR is from. If you'd prefer I can do it for you in another PR and keep you in the commit author/signed-off?

@keitwb
Copy link
Contributor Author

keitwb commented Jun 23, 2022

This should be good for a rebase, I've rebased and run yarn checkstyle -w to run the formatter on another branch and it all looks happy. I'd do it, but I don't think I have access to change the branch this PR is from. If you'd prefer I can do it for you in another PR and keep you in the commit author/signed-off?

Ok, I rebased.

@Hexxeh
Copy link
Contributor

Hexxeh commented Jun 27, 2022

This should be good for a rebase, I've rebased and run yarn checkstyle -w to run the formatter on another branch and it all looks happy. I'd do it, but I don't think I have access to change the branch this PR is from. If you'd prefer I can do it for you in another PR and keep you in the commit author/signed-off?

Ok, I rebased.

You'll need to run yarn checkstyle -w as well to pass CI, there's normally a Git hook that does this automatically but I'm not sure why it hasn't run it in your case. Sorry about that!

This replaces the old output format in favor of a V8 Heap Snapshot
which is usable in Chrome Dev Tools.

This will hopefully be useful in debugging heap usage even though
it is not quite as full of metadata compared to the heap snapshots taken
from a normal V8 app.

This also adds the ability to export the heap snapshot to GEXF for use
in graphing tools like Gephi.

Also included is the ability to launch a REPL to manually explore the heap
graph.

Signed-off-by: Ben Keith <keitwb@gmail.com>
@keitwb
Copy link
Contributor Author

keitwb commented Jun 27, 2022

ok, yeah I think the hooks didn't run because I only did a rebase instead of a regular commit. Should be good now.

@Hexxeh Hexxeh merged commit 4dab0d8 into Fitbit:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants