Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade keytar #196

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Upgrade keytar #196

merged 1 commit into from
Jul 4, 2022

Conversation

SergioMorchon
Copy link
Contributor

@SergioMorchon SergioMorchon commented Jul 3, 2022

Fixes keytar dependency build issue on Windows.

I ran the following command:

yarn upgrade-interactive --latest

And selected keytar to be upgraded to the latest major 7.9 that seems to avoid this blocker issue on Windows machines:

error C:\Users\-\dev\developer-bridge\node_modules\keytar: Command failed.
Exit code: 1
Command: prebuild-install || node-gyp rebuild
Arguments:
Directory: C:\Users\-\dev\developer-bridge\node_modules\keytar
Output:
prebuild-install WARN install No prebuilt binaries found (target=18.4.0 runtime=node arch=x64 libc= platform=win32)
gyp info it worked if it ends with ok
gyp info using node-gyp@8.4.1
gyp info using node@18.4.0 | win32 | x64
gyp ERR! find Python
gyp ERR! find Python Python is not set from command line or npm configuration
gyp ERR! find Python Python is not set from environment variable PYTHON
gyp ERR! find Python checking if "python3" can be used
gyp ERR! find Python - "python3" is not in PATH or produced an error
gyp ERR! find Python checking if "python" can be used
gyp ERR! find Python - "python" is not in PATH or produced an error
gyp ERR! find Python checking if Python is C:\Users\-\AppData\Local\Programs\Python\Python39\python.exe
gyp ERR! find Python - "C:\Users\-\AppData\Local\Programs\Python\Python39\python.exe" could not be run
gyp ERR! find Python checking if Python is C:\Program Files\Python39\python.exe
gyp ERR! find Python - "C:\Program Files\Python39\python.exe" could not be run
gyp ERR! find Python checking if Python is C:\Users\-\AppData\Local\Programs\Python\Python39-32\python.exe
gyp ERR! find Python - "C:\Users\-\AppData\Local\Programs\Python\Python39-32\python.exe" could not be run
gyp ERR! find Python checking if Python is C:\Program Files\Python39-32\python.exe
gyp ERR! find Python - "C:\Program Files\Python39-32\python.exe" could not be run
gyp ERR! find Python checking if Python is C:\Program Files (x86)\Python39-32\python.exe
gyp ERR! find Python - "C:\Program Files (x86)\Python39-32\python.exe" could not be run
gyp ERR! find Python checking if Python is C:\Users\-\AppData\Local\Programs\Python\Python38\python.exe
gyp ERR! find Python - "C:\Users\-\AppData\Local\Programs\Python\Python38\python.exe" could not be run
gyp ERR! find Python checking if Python is C:\Program Files\Python38\python.exe
gyp ERR! find Python - "C:\Program Files\Python38\python.exe" could not be run
gyp ERR! find Python checking if Python is C:\Users\-\AppData\Local\Programs\Python\Python38-32\python.exe
gyp ERR! find Python - "C:\Users\-\AppData\Local\Programs\Python\Python38-32\python.exe" could not be run
gyp ERR! find Python checking if Python is C:\Program Files\Python38-32\python.exe
gyp ERR! find Python - "C:\Program Files\Python38-32\python.exe" could not be run
gyp ERR! find Python checking if Python is C:\Program Files (x86)\Python38-32\python.exe
gyp ERR! find Python - "C:\Program Files (x86)\Python38-32\python.exe" could not be run
gyp ERR! find Python checking if Python is C:\Users\-\AppData\Local\Programs\Python\Python37\python.exe
gyp ERR! find Python - "C:\Users\-\AppData\Local\Programs\Python\Python37\python.exe" could not be run
gyp ERR! find Python checking if Python is C:\Program Files\Python37\python.exe
gyp ERR! find Python
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Python installation to use
gyp ERR! stack     at PythonFinder.fail (C:\Users\-\dev\developer-bridge\node_modules\node-gyp\lib\find-python.js:330:47)
gyp ERR! stack     at PythonFinder.runChecks (C:\Users\-\dev\developer-bridge\node_modules\node-gyp\lib\find-python.js:159:21)
gyp ERR! stack     at PythonFinder.<anonymous> (C:\Users\-\dev\developer-bridge\node_modules\node-gyp\lib\find-python.js:228:18)
gyp ERR! stack     at PythonFinder.execFileCallback (C:\Users\-\dev\developer-bridge\node_modules\node-gyp\lib\find-python.js:294:16)
gyp ERR! stack     at exithandler (node:child_process:397:5)
gyp ERR! stack     at ChildProcess.errorhandler (node:child_process:409:5)
gyp ERR! stack     at ChildProcess.emit (node:events:537:28)
gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:289:12)
gyp ERR! stack     at onErrorNT (node:internal/child_process:476:16)
gyp ERR! stack     at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
gyp ERR! System Windows_NT 10.0.22000
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\-\\dev\\developer-bridge\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\-\dev\developer-bridge\node_modules\keytar
gyp ERR! node -v v18.4.0
gyp ERR! node-gyp -v v8.4.1
gyp ERR! not ok

@SergioMorchon SergioMorchon requested a review from a team July 3, 2022 16:15
Fixes keytar dependency build issue on Windows

Signed-off-by: Sergio Morchón Poveda <sergio.morchon@outlook.com>
@coveralls
Copy link

coveralls commented Jul 4, 2022

Coverage Status

Coverage remained the same at 94.25% when pulling f1a498f on SergioMorchon:upgrade-keytar into 4dab0d8 on Fitbit:master.

@Hexxeh Hexxeh merged commit b75c933 into Fitbit:master Jul 4, 2022
@SergioMorchon SergioMorchon deleted the upgrade-keytar branch July 4, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants