Allow buildTargets to be missing or empty if native components are provided #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovided Signed-off-by: Liam McLoughlin <lmcloughlin@fitbit.com>
|
Coverage decrease is in |
npclaudiu
approved these changes
Jun 10, 2019
badescuga
reviewed
Jun 12, 2019
| const diagnostics = constrainedSetDiagnostics({ | ||
| actualValues: buildTargets, | ||
| knownValues: knownBuildTargets, | ||
| valueTypeNoun: 'build targets', | ||
| notFoundIsFatal: true, | ||
| }); | ||
|
|
||
| if (buildTargets.length === 0) { | ||
| if ( | ||
| (buildTargets === undefined || buildTargets.length === 0) && |
There was a problem hiding this comment.
i think that having buildTargets undefined as a valid option is in contrast with what our types are saying. We should change our typings too and adjust.
There was a problem hiding this comment.
It's only valid if there are native components, which is what this is checking for.
If it's undefined, the types are still correct, because the normalization function will default it to an empty array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.