Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correting way to call async #13

Merged
merged 2 commits into from Feb 14, 2019
Merged

Correting way to call async #13

merged 2 commits into from Feb 14, 2019

Conversation

uasouz
Copy link
Contributor

@uasouz uasouz commented Jan 16, 2019

On Python 3.7 async is a reserved keyword,so i used getattr() to get it

Adding fix for python 3.7 asyncio(async now is a reserved word)
async is a reserved keyword on python 3.7
@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   75.92%   75.92%           
=======================================
  Files           5        5           
  Lines         324      324           
=======================================
  Hits          246      246           
  Misses         78       78
Impacted Files Coverage Δ
wsstat/clients.py 70.65% <0%> (ø) ⬆️
wsstat/demo.py 47.82% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c7d33...c52f24b. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.926% when pulling c52f24b on uasouz:master into 58c7d33 on Fitblip:master.

@Fitblip
Copy link
Owner

Fitblip commented Feb 14, 2019

Interesting, thanks for the PR! Not sure why travis/codecov barfed here, but this should be good to merge once I make sure tests are passing 👍

@Fitblip
Copy link
Owner

Fitblip commented Feb 14, 2019

Yeah this looks good. I'll merge and cut a new release, thanks!

@Fitblip Fitblip merged commit 44f1437 into Fitblip:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants