Feat/auth form #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ezequiel-Schejtman
requested changes
Apr 8, 2023
app/AuthForm.tsx
Outdated
| }); | ||
| const data = await res.json(); | ||
|
|
||
| console.log(data); |
There was a problem hiding this comment.
Me parece que hay un problema con el logger en un browser environment (winstonjs/winston#925 (comment)). Me esta tirando este error:
Import trace for requested module:
./node_modules/winston/dist/winston/transports/file.js
./node_modules/winston/dist/winston/transports/index.js
./node_modules/winston/dist/winston.js
./node_modules/@fiu-fit/common/dist/utils/logger-utility.js
./node_modules/@fiu-fit/common/dist/utils/index.js
./node_modules/@fiu-fit/common/dist/index.js
./app/AuthForm.tsx
wait - compiling /_error (client and server)...
error - ./node_modules/winston/dist/winston/tail-file.js:9:0
Module not found: Can't resolve 'fs'
No se si se te ocurre como solucionarlo o configure algo mal?
app/AuthForm.tsx
Outdated
Comment on lines
19
to
26
| const res = await fetch("http://localhost:8080/auth/login", { | ||
| method: "POST", | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| }, | ||
| body: body, | ||
| }); | ||
| const data = await res.json(); |
There was a problem hiding this comment.
Can we use axios for this? We'll also need to not hard-code this URL.
app/AuthForm.tsx
Outdated
Comment on lines
37
to
59
| <FormInput | ||
| name="email" | ||
| label="Correo electrónico" | ||
| type="text" | ||
| className="col-span-2" | ||
| /> | ||
| <FormInput | ||
| name="password" | ||
| label="Contraseña" | ||
| type="password" | ||
| className="col-span-2" | ||
| /> | ||
| <button | ||
| type="submit" | ||
| className="text-white bg-blue-600 hover:bg-blue-700 col-span-2 button" | ||
| > | ||
| Iniciar sesión | ||
| </button> | ||
| <Link href="/register" className={`button ${styles.extra_button}`}> | ||
| Registrarse | ||
| </Link> | ||
| <Link href="/forgot-password" className={`button ${styles.extra_button}`}> | ||
| Recuperar contraseña |
There was a problem hiding this comment.
Decis que pongamos la UI en ingles? Me parece mejor dejarla en español por un tema de que la consigna esta en español tambien
app/register/RegisterForm.tsx
Outdated
Comment on lines
25
to
32
| const res = await fetch("http://localhost:8080/auth/register", { | ||
| method: "POST", | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| }, | ||
| body: body, | ||
| }); | ||
| const data = await res.json(); |
There was a problem hiding this comment.
Same thing here; use Axios & don't hard-code the URL.
app/register/RegisterForm.tsx
Outdated
Comment on lines
44
to
73
| <FormInput | ||
| name="firstName" | ||
| label="Nombre" | ||
| type="text" | ||
| className="col-span-2 sm:col-span-1" | ||
| /> | ||
| <FormInput | ||
| name="lastName" | ||
| label="Apellido" | ||
| type="text" | ||
| className="col-span-2 sm:col-span-1" | ||
| /> | ||
| <FormInput | ||
| name="email" | ||
| label="Email" | ||
| type="text" | ||
| className="col-span-2" | ||
| /> | ||
| <FormInput | ||
| name="password" | ||
| label="Contraseña" | ||
| type="password" | ||
| className="col-span-2" | ||
| /> | ||
| <FormInput | ||
| name="passwordConfirmation" | ||
| label="Confirmar contraseña" | ||
| type="password" | ||
| className="col-span-2" | ||
| /> |
There was a problem hiding this comment.
Refactor this, there's no need to repeat this much code.
There was a problem hiding this comment.
Lo cambie, no me termina de convencer como quedo, acepto sugerencias :D
ianshih2003
requested changes
Apr 10, 2023
app/register/RegisterForm.tsx
Outdated
| ...formData, | ||
| role: ADMIN_ROLE, | ||
| }; | ||
| const body = JSON.stringify(registerData); |
app/register/RegisterForm.tsx
Outdated
Comment on lines
59
to
61
| headers: { | ||
| "Content-Type": "application/json", | ||
| }, |
…into feat/auth-form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added login and register form and connected it to the API gateway