Fully enable IPv6 in the VPC (as new opt-in variable) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danopia
force-pushed
the
upstream-ipv6
branch
from
48497a1
to
3dddcfa
Compare
danopia
force-pushed
the
upstream-ipv6
branch
from
3dddcfa
to
6852c82
Compare
snovikov
previously approved these changes
Oct 22, 2021
|
@danopia can you please resolve conflict and rebase your branch? |
Dualstack ALB was already an option, but the VPC wasn't fully set up for it. I made this a variable to preserve previous behavior, but any new users looking for dualstack will probably want to enable it.
danopia
force-pushed
the
upstream-ipv6
branch
from
7e618f1
to
1fd51d5
Compare
|
Hi, I've restated my changes as a fresh signed commit. The conflict was only in Also, as mentioned in my original comment I also have two other changes to this module which are included in this comparison: parameterizing |
danvaida
approved these changes
Oct 25, 2021
|
Thanks @danopia for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo from Berlin 👋
I noticed that the VPC resource always has IPv6 on, and there's a variable to set
dualstackon the ALB, but there were some pieces missing in the middle. Specifically the default route and security group ingress for IPv6 traffic.When I applied the module as-is, the ALB's AAAA records were created, but trying to connect to them just resulted in a timeout / no packets in response.
This PR adds a variable to preserve previous behavior by default, but any new users looking for dualstack will probably want to enable it. I'm not sure how dualstack would be used right now unless you update the routing manually after setting up this module.
In my fork I also added a couple ARN outputs and a variable for specifying the IPv4 newbits. I figured I'd submit this PR first and ask if the other variable and outputs make sense for a further PR.
Thanks for your module and time!