Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default security settings for public repositories #42

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

snovikov
Copy link
Contributor

@snovikov snovikov commented Jan 9, 2023

⚠️ This is not a final fix, but rather an intermediate work-around.

Related bugs:

TL;DR

There are multiple issues with security_and_analysis. It is all the time set for public repositories, but have a buggy behaviour.
I case if you not set for public repo provider tries to remove settings, which results in error:

422 Advanced security is always available for public repos

In case if you set advanced_security to enabled, it will still produce error, but only on initial apply.

@snovikov snovikov added the bug Something isn't working label Jan 9, 2023
@snovikov snovikov self-assigned this Jan 9, 2023
@snovikov snovikov requested a review from a team as a code owner January 9, 2023 12:33
@snovikov snovikov merged commit 605d3c6 into master Jan 9, 2023
@snovikov snovikov deleted the fix-public-security branch January 9, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants