-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching does not implement a max size #101
Comments
@JFCote @vpetrusevici - mentioning you both here as I know you both worked on the caching implementation. I'm keen to get your thoughts here on whether there's a reason that a max size was not implemented originally. |
@matthewelwell As far as I remember, I think I didn't add this kind of limitation as it was a "first draft" and "best effort" kind of thing. I definitely think it would be a great improvement to prevent very big users to bust the memory of their applications. |
Understood - thanks @JFCote. |
Flagsmith feature linked:
|
Flagsmith Feature
|
Flagsmith Feature
|
Flagsmith Feature
|
Currently the caching implementation does not implement a max size. We should add a configurable limit to the size of the cache to ensure that there are no memory concerns when using the cache implementation in the client.
The text was updated successfully, but these errors were encountered: