Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching does not implement a max size #101

Open
matthewelwell opened this issue Apr 25, 2024 · 7 comments
Open

Caching does not implement a max size #101

matthewelwell opened this issue Apr 25, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@matthewelwell
Copy link
Contributor

Currently the caching implementation does not implement a max size. We should add a configurable limit to the size of the cache to ensure that there are no memory concerns when using the cache implementation in the client.

@matthewelwell matthewelwell added enhancement New feature or request good first issue Good for newcomers labels Apr 25, 2024
@matthewelwell
Copy link
Contributor Author

matthewelwell commented Apr 25, 2024

@JFCote @vpetrusevici - mentioning you both here as I know you both worked on the caching implementation. I'm keen to get your thoughts here on whether there's a reason that a max size was not implemented originally.

@JFCote
Copy link
Contributor

JFCote commented Apr 25, 2024

@matthewelwell As far as I remember, I think I didn't add this kind of limitation as it was a "first draft" and "best effort" kind of thing.

I definitely think it would be a great improvement to prevent very big users to bust the memory of their applications.

@matthewelwell
Copy link
Contributor Author

Understood - thanks @JFCote.

Copy link

flagsmith bot commented Jun 4, 2024

Flagsmith feature linked: secret_button
Default Values:

Environment Enabled Value Last Updated (UTC)
Development ✅ Enabled {colour: "#080808"} 2024-04-30 22:54:05
Production ✅ Enabled {colour: "#080808"} 2024-03-28 20:58:49

Copy link

flagsmith bot commented Jun 4, 2024

Flagsmith Feature secret_button has been updated:

Environment Enabled Value Last Updated (UTC)
Development ❌ Disabled {colour: "#080808"} 2024-06-04 16:36:40

Copy link

flagsmith bot commented Jun 4, 2024

Flagsmith Feature secret_button has been updated:

Environment Enabled Value Last Updated (UTC)
Development ✅ Enabled {colour: "#080808"} 2024-06-04 16:40:28

Copy link

flagsmith bot commented Jun 4, 2024

Flagsmith Feature secret_button has been updated:

Environment Enabled Value Last Updated (UTC)
Development ❌ Disabled {colour: "#080808"} 2024-06-04 16:41:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants