Identifier/trait confusion when using cacheOptions: { skipAPI: true }

[rolodato]

Using a slightly-modified version of the React example here, I can reproduce the issue below Flagsmith/flagsmith-js-examples@main...rolodato:flagsmith-js-examples-repro-17cf4148:main

I'm not sure what's going on here exactly, but you can see in some conditions we are using cached traits from a previous identity and inserting them into an unrelated identity. Identity B should never have a name: "A" trait set.

id-trait-confusion-react.mov

[kyle-ssg]

If I understand this issue right, it has nothing to do with caching.

The problem is

• Identifying with user a stores returned traits locally
• calling identify again with a new identity combines previously set traits with the request for the new identity. It does this to allow for users to set traits prior to identifying, this is a common requirement.

The solution I think is that if we call identify and the sdk is already identified it should clear out the traits and just use whatever is provided at that time.

[kyle-ssg]

@rolodato I believe this is resolved please start again with new identities without traits using flagsmith@4.0.2-beta-1

[matthewelwell]

Yes, I've tested and the new version seems to have resolved the issue 👍