Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow signups when invited and in PREVENT_SIGNUP mode #2448

Merged
merged 4 commits into from
Jul 17, 2023
Merged

fix: Allow signups when invited and in PREVENT_SIGNUP mode #2448

merged 4 commits into from
Jul 17, 2023

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?

Changes

This allows the user to signup when invited in a PREVENT_SIGNUP environment.

How did you test this code?

Ran the project in PREVENT_SIGNUP mode

@vercel
Copy link

vercel bot commented Jul 17, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 8:38am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 8:38am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 8:38am

@kyle-ssg kyle-ssg changed the title Allow signups when invited and in PREVENT_SIGNUP mode chore: Allow signups when invited and in PREVENT_SIGNUP mode Jul 17, 2023
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jul 17, 2023
@kyle-ssg kyle-ssg changed the title chore: Allow signups when invited and in PREVENT_SIGNUP mode fix: Allow signups when invited and in PREVENT_SIGNUP mode Jul 17, 2023
@kyle-ssg kyle-ssg linked an issue Jul 17, 2023 that may be closed by this pull request
Setting PREVENT_SIGNUP to True breaks user invitations #2445
Closed
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited

Uffizzi Preview deployment-31037 was deleted.

@kyle-ssg kyle-ssg requested review from dabeeeenster, matthewelwell, a team and khvn26 and removed request for dabeeeenster, matthewelwell and khvn26 July 17, 2023 15:42
@matthewelwell matthewelwell merged commit 10719eb into main Jul 17, 2023
14 checks passed
@matthewelwell matthewelwell deleted the fix/allow_signup_on_invite branch July 17, 2023 16:33
@dabeeeenster dabeeeenster mentioned this pull request Jul 17, 2023
Merged
@dabeeeenster dabeeeenster mentioned this pull request Aug 22, 2023
Closed
This was referenced Aug 29, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting PREVENT_SIGNUP to True breaks user invitations
2 participants
@kyle-ssg @matthewelwell