Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Compare identities #2616

Merged
merged 7 commits into from
Aug 10, 2023
Merged

feat: Compare identities #2616

merged 7 commits into from
Aug 10, 2023

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Aug 9, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Note: Due to husky not being installed on other contributors machines, it looks like there are some lint issues that this fixed. This problem should be resolved by running lint in GH actions

UI

image

Permissions

One thing to take into account is whether the user has permissions to view identities for the selected environment, this handles that case

image

How did you test this code?

Tested against users in production.

# Conflicts:
#	frontend/common/types/requests.ts
#	frontend/common/types/responses.ts
#	frontend/web/components/FeatureRow.js
#	frontend/web/components/FeatureValue.js
#	frontend/web/components/OrganisationUsage.tsx
#	frontend/web/components/modals/CreateEditIntegrationModal.js
#	frontend/web/components/modals/CreateFlag.js
#	frontend/web/components/modals/CreateSegment.tsx
#	frontend/web/components/pages/BetaFeaturesPage.js
#	frontend/web/components/pages/EnvironmentSettingsPage.js
#	frontend/web/components/pages/UserPage.js
@kyle-ssg kyle-ssg marked this pull request as draft August 9, 2023 17:28
@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 6:15pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 6:15pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 6:15pm

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Uffizzi Preview deployment-33057 was deleted.

@kyle-ssg kyle-ssg changed the title feature: Compare identities feat: Compare identities Aug 9, 2023
Copy link
Contributor

@dabeeeenster dabeeeenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyle-ssg kyle-ssg merged commit aafce13 into main Aug 10, 2023
21 checks passed
@kyle-ssg kyle-ssg deleted the feature/compare_users branch August 10, 2023 13:31
This was referenced Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "Compare Identities" tab to our Compare page
2 participants