Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow registration via invite link if ALLOW_REGISTRATION_WITHOUT_INVITE is False #2731

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix: allow registration via invite link if ALLOW_REGISTRATION_WITHOUT_INVITE is False #2731

merged 1 commit into from
Sep 5, 2023

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes #1563

How did you test this code?

Added unit tests

@matthewelwell matthewelwell requested review from a team and novakzaballa September 4, 2023 17:18
@matthewelwell matthewelwell linked an issue Sep 4, 2023 that may be closed by this pull request
Unable to use OAuth login with invite links if ALLOW_REGISTRATION_WITHOUT_INVITE=false #1563
Closed
@vercel
Copy link

vercel bot commented Sep 4, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 5:21pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 5:21pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 5:21pm

@github-actions github-actions bot added the api Issue related to the REST API label Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023 •
edited

Uffizzi Preview deployment-35173 was deleted.

novakzaballa
novakzaballa approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewelwell matthewelwell merged commit 73705d5 into main Sep 5, 2023
16 checks passed
@matthewelwell matthewelwell deleted the fix/1563-unable-to-use-oauth-login-with-invite-links-if-allow_registration_without_invite=false branch September 5, 2023 16:07
@dabeeeenster dabeeeenster mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

Assignees
No one assigned
Labels
api Issue related to the REST API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use OAuth login with invite links if ALLOW_REGISTRATION_WITHOUT_INVITE=false
2 participants
@matthewelwell @novakzaballa