Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deleting a project causes multiple UI issues #2749

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: Deleting a project causes multiple UI issues #2749

merged 1 commit into from
Sep 7, 2023

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Convert project ID to int to delete it from the local store.
  • Removed the item 'lastEnv' from AsyncStorage when the project is deleted.

How did you test this code?

  • Create and delete a project.

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Sep 5, 2023 10:24pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Sep 5, 2023 10:24pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Sep 5, 2023 10:24pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023 •
edited

Uffizzi Preview deployment-35272 was deleted.

@novakzaballa novakzaballa requested review from a team and khvn26 September 6, 2023 04:36
@novakzaballa novakzaballa linked an issue Sep 6, 2023 that may be closed by this pull request
Deleting a project causes multiple UI issues #2704
Closed
4 tasks
@novakzaballa novakzaballa merged commit 8cd144b into main Sep 7, 2023
14 checks passed
@novakzaballa novakzaballa deleted the fix/deleting-a-project-causes-multiple-ui-issues branch September 7, 2023 13:19
@dabeeeenster dabeeeenster mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khvn26 khvn26 khvn26 approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting a project causes multiple UI issues
2 participants
@novakzaballa @khvn26