Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Webhook button not working #2753

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add type = 'submit' to the offending button.

How did you test this code?

Tested manually against local dev env

  1. Go to the "Manage" option at the top menu bar
  2. Click on the "Webhooks" tab
  3. Create a new Webhook or skip this step if you already have a Webhook
  4. Edit the Webhook
  5. Make changes to the Webhook and try to save the changes by clicking the "Update Webhook" button
  6. See that the data has been updated in both the FE and backend by reloading the page.

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 2:21am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 2:21am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Sep 7, 2023 2:21am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Uffizzi Preview deployment-35395 was deleted.

@novakzaballa novakzaballa requested review from a team and gagantrivedi September 7, 2023 02:36
@novakzaballa novakzaballa merged commit 8566fe0 into main Sep 7, 2023
14 checks passed
@novakzaballa novakzaballa deleted the fix/update-webhook-button-not-working branch September 7, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Webhook button not working
2 participants