Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Environment webhook update button not working #2788

Merged

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixed Environment Webhook update button not working by adding the type='submit' attirbute. It was probably accidentally removed during the redesign.

How did you test this code?

Manually:

  1. Go to the "Environment Settings" option at the left menu panel
  2. Click on the "Webhooks" tab
  3. Create a new Webhook or skip this step if you already have a Webhook
  4. Edit the Webhook
  5. Make changes to the Webhook and save the changes by clicking the "Update Webhook" button
  6. See that the changes are saved now and can be retrieved refreshing the page and following the same steps.

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Sep 19, 2023 5:24am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Sep 19, 2023 5:24am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Sep 19, 2023 5:24am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Sep 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Uffizzi Preview deployment-36265 was deleted.

@novakzaballa novakzaballa linked an issue Sep 19, 2023 that may be closed by this pull request
3 tasks
@gagantrivedi gagantrivedi merged commit 5f92a00 into main Sep 19, 2023
18 checks passed
@gagantrivedi gagantrivedi deleted the fix/environment-webhook-update-button-not-working branch September 19, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Webhook button not working
2 participants