Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Last Influx data updated at never updates #2802

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Added a filter for when the "influx update at" field is null.

How did you test this code?

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 6:11pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 6:11pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 6:11pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Uffizzi Preview deployment-36637 was deleted.

@novakzaballa novakzaballa requested review from a team and gagantrivedi September 25, 2023 13:22
)
.order_by("-influx_updated_at")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are only fetching the first element, we can do desc(null_last=True) /
docs: https://docs.djangoproject.com/en/3.1/ref/models/expressions/#django.db.models.Expression.desc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e62be85) 95.53% compared to head (b420214) 95.53%.

❗ Current head b420214 differs from pull request most recent head faec4e8. Consider uploading reports for the commit faec4e8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2802   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files         994      994           
  Lines       28072    28072           
=======================================
  Hits        26818    26818           
  Misses       1254     1254           
Files Coverage Δ
api/sales_dashboard/views.py 61.29% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@novakzaballa novakzaballa merged commit 929afeb into main Sep 27, 2023
20 checks passed
@novakzaballa novakzaballa deleted the fix/last-influx-data-updated-at-never-updates branch September 27, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In sales dashboard, Last Influx data updated at never updates
3 participants