Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect default_percentage_allocation on import, binary flags imported as multivariate #2841

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 9, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This fixes two issues with LD importer:

  • multivariate options created with 100% default percentage, should be 0
  • standard valued features treated as multivariate with 100/0 variations

How did you test this code?

Extended unit tests.

@khvn26 khvn26 requested review from a team and gagantrivedi October 9, 2023 17:47
@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 4:55pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 4:55pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 4:55pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Uffizzi Preview deployment-38059 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4f7464b) 95.59% compared to head (19b29f5) 95.60%.
Report is 2 commits behind head on main.

❗ Current head 19b29f5 differs from pull request most recent head da59ae2. Consider uploading reports for the commit da59ae2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2841   +/-   ##
=======================================
  Coverage   95.59%   95.60%           
=======================================
  Files        1009     1009           
  Lines       28833    28865   +32     
=======================================
+ Hits        27562    27595   +33     
+ Misses       1271     1270    -1     
Files Coverage Δ
api/features/feature_types.py 100.00% <100.00%> (ø)
api/integrations/launch_darkly/services.py 100.00% <100.00%> (+0.96%) ⬆️
...s/unit/integrations/launch_darkly/test_services.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 merged commit 619c3f5 into main Oct 12, 2023
20 checks passed
@khvn26 khvn26 deleted the fix/ld-importer-incorrect-mv-options branch October 12, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants