Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle null tooltip data #2892

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: Handle null tooltip data #2892

merged 1 commit into from
Oct 26, 2023

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Oct 26, 2023 •
edited

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Please describe.

How did you test this code?

Prior to this PR if you supply null data to a tooltip it will throw an exception

Before / After
image

@vercel
Copy link

vercel bot commented Oct 26, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 9:47am
flagsmith-frontend-preview 🔄 Building (Inspect) Visit Preview Oct 26, 2023 9:47am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 9:47am

@kyle-ssg kyle-ssg changed the title Handle null tooltip data fix: Handle null tooltip data Oct 26, 2023
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Oct 26, 2023
@matthewelwell matthewelwell added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit a1190ae Oct 26, 2023
17 of 18 checks passed
@matthewelwell matthewelwell deleted the fix/handle_null_tooltip_data branch October 26, 2023 09:49
@dabeeeenster dabeeeenster mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyle-ssg @matthewelwell